Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPD priority inversion #612

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix SPD priority inversion #612

wants to merge 4 commits into from

Commits on Jun 16, 2022

  1. stm32h7-i2c: switch I2cControl to a trait. 

    This lets the crate provide a default impl, removing some boilerplate
from clients, and also will allow I2cControl impls to have _state,_
which is critical for using one to implement an IPC server in the spd
proxy.
    @cbiffle
    cbiffle committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    b11db1f View commit details
    Browse the repository at this point in the history

  2. build/i2c: generate ports on Devices dispo

    @cbiffle
    cbiffle committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5b63fd7 View commit details
    Browse the repository at this point in the history

  3. task/spd: expose IPC interface for EEPROM update. 

    This will provide a channel for feeding EEPROM data into the cache,
incrementally, per the design laid out in #599.
    @cbiffle
    cbiffle committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    dff78cd View commit details
    Browse the repository at this point in the history

  4. gimlet: move SPD EEPROM reads into gimlet-seq 

    The sequencer task now reads the EEPROMs once it's confident they're
available, and pushes the info into the SPD proxy before starting the
host. This eliminates the last blocking I2C transfer from the SPD proxy,
which should improve its liveness. It also eliminates the priority
inversion between SPD (high) and `i2c_driver` (lower).

Fixes #599.
    @cbiffle
    cbiffle committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    cce5dc1 View commit details
    Browse the repository at this point in the history