Add large_payload_behavior arg to net::recv_packet()
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiffle
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Looks right to me.
One reason to do this as two separate operations (...in the future), now that I see the code, is so that they could return more precise error types, since the Discard variant can't produce TooLarge, yet right now clients are forced to handle it by the compiler.
jgallagher
force-pushed
the
net-add-large-payload-behavior
branch
from
1919ab6
to
00a0a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ability of an external UDP source crashing
netclients withClientError::BadLeaseby sending packets in between their lease size and the max size allowed by thenettask.Unfortunately it continues to pour fuel on the fire of
server.rs+vlan.rs.