Fix CI #90
Merged
Fix CI #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
reviewed
Oct 28, 2020
.github/workflows/build.yml
Outdated
Comment on lines
34
to
35
| Invoke-WebRequest -Uri https://github.com/steveklabnik/arm-none-eabi-objcopy/releases/download/9-2020-q2-update/arm-none-eabi-objcopy.exe -OutFile "D:\a\hubris\arm-none-eabi-objcopy.exe" | ||
| echo "D:\a\hubris\" >> $env:GITHUB_PATH |
There was a problem hiding this comment.
Does github provide a better place to put temporary files? I'm a little wary of relying on the D:\a\hubris\ path, else github changes something out from under us.
There was a problem hiding this comment.
I don't know, but I'll look into it more. I agree.
There was a problem hiding this comment.
It seems that there's a not-super-well-documented RUNNER_TEMP variable, see actions/toolkit#518
I've pushed a commit that implements this.
labbott
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some weird reason where scoop isn't installing the right thing. So, let's fix that.
To do so, we are:
This completely removes scoop and all its shenanigans; vcpkg is already
installed in the CI environment.