Validate ByteCount ranges during deserialization
#5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
approved these changes
May 13, 2024
smklein
reviewed
May 13, 2024
Comment on lines
+530
to
+531
| // TODO: custom JsonSchema impl to describe i64::MAX limit; this is blocked by | ||
| // https://github.com/oxidecomputer/typify/issues/589 |
There was a problem hiding this comment.
huh, that's surprising! This is still worth fixing, but to be clear, we'd rely on deserialize either way, so the behavior should be the "same" to clients afterwards, right? Would the only difference be "a more informative schema file"?
There was a problem hiding this comment.
Yeah, this PR fixes the server-side problem. The custom JSON schema would be so (e.g.) the CLI could validate the value even before sending the request.
smklein
approved these changes
May 13, 2024
iliana
added a commit
that referenced
this pull request
May 14, 2024
iliana
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5732.
I tried adding a custom
JsonSchematoo but hit a typify issue; left a link in the TODO comment.