honor XTASK_BIN in tools/install_*_prerequisites.sh
#5860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I also checked that there aren't any other shell scripts in the repo that call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #5482 introduced breakage I didn't account for: being able to run
install_runner_prerequisites.shwithout having Cargo available, which is used by the a4x2 testbed. This change introduces theXTASK_BINenvironment variable which will be used instead ofcargo xtaskif set.The companion PR in a4x2 is https://github.com/oxidecomputer/testbed/pull/49/files.
Tested that all these work:
./tools/install_builder_prerequisites.sh -yXTASK_BIN=target/debug/xtask ./tools/install_builder_prerequisites.sh -y(after building xtask)XTASK_BIN=target/debug/nonexistent-file ./tools/install_builder_prerequisites.sh -y(correctly fails with ENOENT)