One final pass in opte-drv (#214) #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzezeski
force-pushed
the
opte-214-rm-opte-drv
branch
from
63b768f
to
549ac71
Compare
bnaecker
approved these changes
Sep 21, 2022
| #![feature(alloc_error_handler)] | ||
| #![feature(rustc_private)] | ||
| #![deny(unused_must_use)] |
rzezeski
force-pushed
the
opte-214-rm-opte-drv
branch
from
549ac71
to
cb86c37
Compare
- Did a final sweep in opte-drv to see if there was anything else to migrate over to xde. - Moved over the _Unwind_Resume hack. It seems xde has been working fine without it, but I also notice the Rust issue that originally prompted me to create this hack is still marked as open. So I thought it would be best to migrate the hack over to xde just as a safeguard against the problem coming back until that Rust issue is resolved. rust-lang/rust#47493
rzezeski
force-pushed
the
opte-214-rm-opte-drv
branch
from
cb86c37
to
19bf8d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a final sweep in opte-drv to see if there was anything else to migrate over to xde.
Moved over the _Unwind_Resume hack. It seems xde has been working fine without it, but I also notice the Rust issue that originally prompted me to create this hack is still marked as open. So I thought it would be best to migrate the hack over to xde just as a safeguard against the problem coming back until that Rust issue is resolved.
Undefined reference to
_Unwind_Resumerust-lang/rust#47493