a few type handling improvements (#46)

- pass booleans by value through action parameters - use full form of BitVec::<u8,Msb0> in code generation to allow for default instantiation.
oxidecomputer · Apr 29, 2024 · 526a5bd · 526a5bd
1 parent da51567
commit 526a5bd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/codegen/rust/src/lib.rs b/codegen/rust/src/lib.rs
@@ -213,7 +213,7 @@ fn rust_type(ty: &Type) -> TokenStream {
         Type::Bool => quote! { bool },
         Type::Error => todo!("generate error type"),
         Type::Bit(_size) => {
-            quote! { BitVec<u8, Msb0> }
+            quote! { BitVec::<u8, Msb0> }
         }
         Type::Int(_size) => todo!("generate int type"),
         Type::Varbit(_size) => todo!("generate varbit type"),

diff --git a/codegen/rust/src/pipeline.rs b/codegen/rust/src/pipeline.rs
@@ -840,7 +840,11 @@ impl<'a> PipelineGenerator<'a> {
                         control_param_types.push(quote! { &mut #ty });
                     }
                     _ => {
-                        control_param_types.push(quote! { &#ty });
+                        if p.ty == Type::Bool {
+                            control_param_types.push(quote! { #ty });
+                        } else {
+                            control_param_types.push(quote! { &#ty });
+                        }
                     }
                 }
             }
@@ -949,7 +953,11 @@ impl<'a> PipelineGenerator<'a> {
                     control_param_types.push(quote! { &mut #ty });
                 }
                 _ => {
-                    control_param_types.push(quote! { &#ty });
+                    if p.ty == Type::Bool {
+                        control_param_types.push(quote! { #ty });
+                    } else {
+                        control_param_types.push(quote! { &#ty });
+                    }
                 }
             }
         }