Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont flip byte order on fields <= 8 bits #51

Merged
merged 3 commits into from
May 31, 2024
Merged

dont flip byte order on fields <= 8 bits #51

merged 3 commits into from
May 31, 2024

Conversation

rcgoodfellow
Copy link
Collaborator

@rcgoodfellow rcgoodfellow commented May 31, 2024 •
edited
Loading

  • due to bitvector capacity accounting these fields can expand into 2 bytes as vectors, and if we reorder them, the values get corrupted.
  • check for null fields on deserialization
  • fixes panic serializing header #50

@rcgoodfellow
dont flip byte order on fields <= 8 bits
53d2cfd 
due to bitvector capacity accounting these fields can expand into 2
bytes as vectors, and if we reorder them, the values get corrupted.
@rcgoodfellow
check for null fields on deserialization
7b068cb
@rcgoodfellow rcgoodfellow marked this pull request as ready for review May 31, 2024 03:10
@rcgoodfellow rcgoodfellow merged commit 521fe3d into main May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic serializing header
1 participant
@rcgoodfellow