SoftNpu early return on empty guest virtio buffers, bump dlpi crate, fix duplicate crate import issue #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break out of the guest packet processing loop early when there are no bytes to read. This has a non-trivial impact on latency reduction. Bump the dlpi dependency. The latest version is less chatty with logging and the bug previously referenced is no longer an issue since we are not using the async API exported by the dlpi create. Set publish = false on the header check libraries. When importing propolis libraries, because both viona-api and bhyve-api have a sub-crate called header-check, cargo starts screaming.
1 task
pfmooney
approved these changes
Dec 14, 2022
| @@ -4,6 +4,7 @@ version = "0.0.0" | |||
| authors = ["Patrick Mooney <pmooney@oxide.computer>"] | |||
| license = "MPL-2.0" | |||
| build = "build.rs" | |||
| publish = false | |||
There was a problem hiding this comment.
Oh nice. I didn't know about that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoftNpu early return on empty buffers
Break out of the guest packet processing loop early when there are no bytes to read. This has a non-trivial impact on latency reduction.
Bump dlpi
Bump the dlpi dependency. The latest version is less chatty with logging and the bug previously referenced is no longer an issue since we are not using the async API exported by the dlpi create.
Fix import issue
Set
publish = falseon the header check libraries. When importing propolis libraries, because bothviona-apiandbhyve-apihave a sub-crate calledheader-check, cargo starts screaming. This is working around this issue with this fixOther
The changes in propolis-standalone are in response to clippy complaints.