Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build status badges #16

Merged
merged 2 commits into from May 8, 2018
Merged

Conversation

SebastinSanty
Copy link
Collaborator

DataDeps contains status badges so I thought it would be a good idea to include them for this project too.

  • Need to update AppVeyor's badge's security token based badge image url

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           6        6           
  Lines          96       96           
=======================================
  Hits           93       93           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9ef09...9f3f1f7. Read the comment docs.

@oxinabox
Copy link
Owner

oxinabox commented May 8, 2018

Looks good.
I feel like PkgDev used to automatically include these in the template file

Need to update AppVeyor's badge's security token based badge image url

What do you mean?
Seem to be working to me

@SebastinSanty
Copy link
Collaborator Author

SebastinSanty commented May 8, 2018 via email

@oxinabox
Copy link
Owner

oxinabox commented May 8, 2018

Ah right, i get it.
Cool, I have grabbed that and fixed it.
Thanks.

@oxinabox oxinabox merged commit 609d5e1 into oxinabox:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants