Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of sbom for JS #46

Merged
merged 4 commits into from
Aug 8, 2023
Merged

add support of sbom for JS #46

merged 4 commits into from
Aug 8, 2023

Conversation

eyalatox
Copy link
Contributor

@eyalatox eyalatox commented Aug 8, 2023

No description provided.

@eyalatox eyalatox requested a review from nvuillam August 8, 2023 19:02
@eyalatox eyalatox self-assigned this Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ ACTION actionlint 6 3 0.04s
✅ COPYPASTE jscpd yes no 3.26s
⚠️ CSS stylelint 3 0 1 1.14s
✅ DOCKERFILE hadolint 1 0 0.06s
✅ HTML djlint 1 0 0.62s
✅ HTML htmlhint 1 0 0.25s
✅ JSON eslint-plugin-jsonc 19 0 0 2.13s
✅ JSON jsonlint 19 0 0.19s
✅ JSON npm-package-json-lint yes no 0.68s
✅ JSON prettier 19 0 0 1.26s
✅ JSON v8r 19 0 20.68s
⚠️ MARKDOWN markdownlint 10 0 31 1.32s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.34s
✅ REPOSITORY checkov yes no 29.5s
✅ REPOSITORY gitleaks yes no 2.06s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.13s
⚠️ REPOSITORY kics yes 1 18.65s
✅ REPOSITORY secretlint yes no 1.26s
✅ REPOSITORY trivy yes no 4.95s
✅ REPOSITORY trivy-sbom yes no 3.69s
✅ REPOSITORY trufflehog yes no 3.8s
✅ SPELL cspell 57 0 3.89s
✅ SPELL lychee 44 0 4.27s
✅ YAML prettier 12 0 0 0.84s
✅ YAML v8r 12 0 17.8s
✅ YAML yamllint 12 0 0.59s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz check comment + update CHANGELOG.md :)

@@ -5,7 +5,7 @@
"types": "./src/index.ts",
"main": "./dist/index.js",
"scripts": {
"start": "nodemon -r dotenv/config ./src/index.ts dotenv_config_path=../../.env dotenv_config_debug=true",
"start": "ts-node -r dotenv/config ./src/index.ts dotenv_config_path=../../.env dotenv_config_debug=true",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalatox shouldn't you add ts-node in devDependencies , no we can be sure than it is available after npm install ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I'll add it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-node isn't doing watch... why did you replace nodemon?

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@nvuillam nvuillam merged commit bedd23b into main Aug 8, 2023
3 checks passed
@nvuillam nvuillam deleted the js-sbom-support branch August 8, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants