Skip to content

Commit

Permalink
Fix devcontainer Dockerfile typo (fixes #3114) (#3115)
Browse files Browse the repository at this point in the history
* Fix devcontainer Dockerfile typo (fixes #3114)

There was a small typo with the name of the requirements.txt file that
prevented the whole image from being built.

* Remove outdated comment from devcontainer Dockerfile

This comment is no longer relvant and will just confure users.

---------

Co-authored-by: Edouard Choini猫re <27212526+echoix@users.noreply.github.com>
Co-authored-by: Nicolas Vuillamy <nicolas.vuillamy@gmail.com>
  • Loading branch information
3 people committed Nov 18, 2023
1 parent 4255a7e commit 7420370
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .devcontainer/Dockerfile
Expand Up @@ -8,9 +8,8 @@ FROM mcr.microsoft.com/vscode/devcontainers/python:0-${VARIANT}
ARG NODE_VERSION="16"
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi

# [Optional] If your pip requirements rarely change, uncomment this section to add them to the image.
COPY .config/python/dev/requirements.txt /tmp/pip-tmp/
RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.dev.txt \
RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.txt \
&& rm -rf /tmp/pip-tmp

RUN npm install markdown-table-formatter -g
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -19,7 +19,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l
- Update lintr links to their current locations, by @echoix in [#3122](https://github.com/oxsecurity/megalinter/issues/3122)
- Update Pylint links to their current locations, by @echoix in [#3116](https://github.com/oxsecurity/megalinter/issues/3116)
- Fix way to install powershell on Alpine linux image

- Fix issue with VS Code devcontainer not building [#3114](https://github.com/oxsecurity/megalinter/issues/3114)

- CI
- Upgrade pymdown-extensions and markdown, by @BryanQuigley in [#3053](https://github.com/oxsecurity/megalinter/pull/3053)
Expand Down

0 comments on commit 7420370

Please sign in to comment.