Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secretlint should respect megalinter ignored files/folders instead of .gitignore #1277

Closed
schorlton opened this issue Feb 16, 2022 · 6 comments
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@schorlton
Copy link
Contributor

Opening this up as a separate issue from #1207 (comment) to keep it on your radar as it really does slow down the megalinter experience dramatically. Thanks again!!!

@schorlton schorlton added the bug Something isn't working label Feb 16, 2022
@nvuillam
Copy link
Member

@schorlton now that .gitignore is automatically sent to secretlint when there is a gitignore + no secretlintignore, what do you think is remaining to do ? ^^

@schorlton
Copy link
Contributor Author

Hi @nvuillam , thanks for circling back. Ideally secretlint would respect the ignored files in .mega-linter.yml instead of requiring its own secretlintignore? If secretlint needs a file listing files to ignore, perhaps something like writing megalinter's ignored files to a temp file and passing that to secretlint?

@nvuillam
Copy link
Member

nvuillam commented Mar 1, 2022

It would work if we had a .megalinterignore with same format than .gitignore ... maybe someday :) ( I agree that FILTER_REGEX_EXCLUDE is not so nice to use... )

@schorlton
Copy link
Contributor Author

No worries! I seems like megalinter has a list of files internally that it is ignoring after it parses FILTER_REGEX_EXCLUDE...why not write that list to a tempfile and specify that tempfile to secretlint (or put it in in secretlintignore) if possible?

@nvuillam
Copy link
Member

nvuillam commented Mar 2, 2022

MegaLinter keeps the "not filtered" list of files, but not the filtered ones... maybe it could indeed be possible, but to be honest, it will probably wait for v6 except if a good soul decides to make a PR before ^^

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

2 participants