Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Update editorconfig-checker #1282

Open
Kurt-von-Laven opened this issue Feb 19, 2022 · 18 comments · Fixed by #1475
Open

Automatically Update editorconfig-checker #1282

Kurt-von-Laven opened this issue Feb 19, 2022 · 18 comments · Fixed by #1475
Labels
enhancement New feature or request nostale This issue or pull request is not stale, keep it open

Comments

@Kurt-von-Laven
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Editorconfig-checker 2.4.0 was released on December 7th, 2021, but MegaLinter is still on editorconfig-checker 2.3.5.

Describe the solution you'd like
Include editorconfig-checker in automated updates.

Describe alternatives you've considered
Manually bump the version of editorconfig-checker one time.

Additional context
There could very well be a good reason not to automatically update editorconfig-checker that I lack context on (e.g., perhaps it broke us in the past).

@Kurt-von-Laven Kurt-von-Laven added the enhancement New feature or request label Feb 19, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 22, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 22, 2022
@Kurt-von-Laven Kurt-von-Laven added the nostale This issue or pull request is not stale, keep it open label Apr 15, 2022
@Kurt-von-Laven
Copy link
Collaborator Author

I am beginning to suspect this may not be a MegaLinter issue so much as editorconfig-checker/editorconfig-checker.javascript#385. We use that npm package, which wraps editorconfig-checker itself, so maybe the npm package (in conjunction with some caching on our end?) is the cause of the editorconfig-checker version remaining at 2.3.5.

@nvuillam
Copy link
Member

It seems there is a go installer, let's try it :)

go install github.com/editorconfig-checker/editorconfig-checker/cmd/editorconfig-checker@latest

@Kurt-von-Laven
Copy link
Collaborator Author

Kurt-von-Laven commented Jun 19, 2022

I may be overlooking the obvious, but I am reopening this issue, because the release of editorconfig-checker 2.5.0 does not appear to have been picked up by the automation. I know the Go installer was able to pick up the previous release (2.4.0) though.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 4, 2022
@Kurt-von-Laven Kurt-von-Laven removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 4, 2022
nvuillam added a commit that referenced this issue Sep 4, 2022
@Kurt-von-Laven Kurt-von-Laven removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Sep 18, 2022
@bdovaz
Copy link
Collaborator

bdovaz commented Jan 8, 2023

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 8, 2023

@nvuillam #1830 why did you close it? I see you've tried this before....

Edit: I see... editorconfig-checker/editorconfig-checker#220

@nvuillam
Copy link
Member

nvuillam commented Jan 8, 2023

Alternative would be to use their docker image with a fixed version then manually update it, like we already do for some linters that do not provide @latest tags ... but we would loose the automatic update :)

Example: https://megalinter.io/latest/descriptors/terraform_tflint/#installation-on-mega-linter-docker-image

@echoix
Copy link
Collaborator

echoix commented Jan 14, 2023

editorconfig-checker/editorconfig-checker#219 Was closed, docker image got published, and a GitHub action was added. Some pretty good maintenance was made in the last day or so.

@nvuillam
Copy link
Member

image

latest is still one year old :/

@echoix
Copy link
Collaborator

echoix commented Jan 14, 2023

He seems working on it today, and we see 2.7.0 out. So maybe wait for the week and see.

@echoix
Copy link
Collaborator

echoix commented Jan 14, 2023

I was curious last weekend and told myself I'd like to play with goreleaser, a thing that seemed to block the repo and the maintainer wanted to have set up to solve a lot of problems. So I'm currently learning about it and see if I could make it work either way. Last weekend's reading had me thinking that it was a quite interesting project!

@rasa
Copy link
Contributor

rasa commented Feb 11, 2023

https://hub.docker.com/r/mstruebing/editorconfig-checker/tags now has tag 2.7.0 as latest. What needs to happen for this version to be used by megalinter?

@echoix
Copy link
Collaborator

echoix commented Feb 11, 2023

A PR changing this line :)

- FROM mstruebing/editorconfig-checker:2.4.0 as editorconfig-checker

@echoix
Copy link
Collaborator

echoix commented Feb 11, 2023

@rasa Do you happen to have a little Go packaging/module organization knowledge? I started working a couple weekends ago on helping that project have better CI releases, that will imply creating a v3 release, but what must be done (in regards to the namespace adding /v2 or /v3) when making major releases after v1?

See editorconfig-checker/editorconfig-checker#204 (comment),
with my branch being https://github.com/echoix/editorconfig-checker/tree/dev/goreleaser

rasa added a commit to rasa/megalinter that referenced this issue Feb 11, 2023
@rasa
Copy link
Contributor

rasa commented Feb 11, 2023

@echoix I haven't worked much with goreleaser, but I'll check out your branch and see if I can help test/debug. Let's continue the discussion in editorconfig-checker/editorconfig-checker#204.

@echoix
Copy link
Collaborator

echoix commented Feb 11, 2023

@rasa

@echoix I haven't worked much with goreleaser, but I'll check out your branch and see if I can help test/debug. Let's continue the discussion in editorconfig-checker/editorconfig-checker#204.

Great! At least it's not a GoReleaser help needed, it's plain Go concepts, since it was my first time using go (but not CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nostale This issue or pull request is not stale, keep it open
Projects
None yet
5 participants