Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear report directory before each run #1502

Closed
dschveninger opened this issue May 31, 2022 · 5 comments
Closed

Clear report directory before each run #1502

dschveninger opened this issue May 31, 2022 · 5 comments
Labels
good first issue Good for newcomers question Further information is requested

Comments

@dschveninger
Copy link

Is there anyway through configuration that you can have the report directory cleared before each run?

@dschveninger dschveninger added the question Further information is requested label May 31, 2022
@Kurt-von-Laven
Copy link
Collaborator

Great question. Not presently, but happy to accept a pull request or else I will get to this eventually. In the meantime my team uses a Bash alias for this purpose.

@Kurt-von-Laven Kurt-von-Laven added the good first issue Good for newcomers label May 31, 2022
@dschveninger
Copy link
Author

We will review the code and submit a PR.

@Kurt-von-Laven
Copy link
Collaborator

Do you or @nvuillam know of a reason it would be desirable to leave the report directory from a previous run around (the present behavior)? I am tempted to say this change doesn't even need to be configurable.

@nvuillam
Copy link
Member

nvuillam commented Jun 2, 2022

I prefer to have a vonfig variable telling to clear report folder before running linters, because i know some use cases in v6 where sarif report file name is customized, so we have different darif report files in the same report folder :)

What about a CLEAR_REPORT_FOLDER config var ? :)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jul 3, 2022
nvuillam added a commit that referenced this issue Jul 17, 2022
@nvuillam nvuillam reopened this Jul 17, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants