Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 Cspell Scans things that are not text files #1648

Closed
ThomasRunting opened this issue Jul 25, 2022 · 4 comments
Closed

V6 Cspell Scans things that are not text files #1648

ThomasRunting opened this issue Jul 25, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@ThomasRunting
Copy link

so on going from megalinter/megalinter:v5 to oxsecurity/megalinter:v6.

CSpell seems to scan svg,msi,dmg,png files from no known reason. On v6

@ThomasRunting ThomasRunting added the bug Something isn't working label Jul 25, 2022
@ThomasRunting
Copy link
Author

v5

+----SUMMARY-----+--------------------------+---------------+-------+-------+--------+--------------+
| Descriptor     | Linter                   | Mode          | Files | Fixed | Errors | Elapsed time |
+----------------+--------------------------+---------------+-------+-------+--------+--------------+
| ✅ COPYPASTE   | jscpd                    | project       |   n/a |       |      0 |        1.34s |
| ✅ CREDENTIALS | secretlint               | project       |   n/a |       |      0 |        3.74s |
| ✅ CSS         | stylelint                | list_of_files |     1 |       |      0 |        1.63s |
| ✅ GIT         | git_diff                 | project       |   n/a |       |      0 |        0.01s |
| ✅ JSON        | eslint-plugin-jsonc      | list_of_files |     2 |       |      0 |        1.51s |
| ✅ JSON        | jsonlint                 | file          |     2 |       |      0 |        1.02s |
| ✅ JSON        | prettier                 | list_of_files |     2 |       |      0 |        1.01s |
| ✅ JSON        | v8r                      | file          |     2 |       |      0 |        5.28s |
| ◬ MARKDOWN     | markdownlint             | list_of_files |    10 |       |      1 |        0.65s |
| ✅ MARKDOWN    | markdown-link-check      | list_of_files |    10 |       |      0 |        8.11s |
| ✅ MARKDOWN    | markdown-table-formatter | list_of_files |    10 |       |      0 |        0.51s |
| ✅ SPELL       | cspell                   | list_of_files |    16 |       |      0 |        3.31s |
| ✅ SPELL       | misspell                 | list_of_files |    15 |       |      0 |         0.1s |
| ✅ YAML        | prettier                 | list_of_files |     2 |       |      0 |        1.01s |
| ✅ YAML        | v8r                      | file          |     2 |       |      0 |        3.37s |
| ✅ YAML        | yamllint                 | list_of_files |     2 |       |      0 |        0.34s |
+----------------+--------------------------+---------------+-------+-------+--------+--------------+

V6

+----SUMMARY----+--------------------------+---------------+-------+-------+--------+--------------+
| Descriptor    | Linter                   | Mode          | Files | Fixed | Errors | Elapsed time |
+---------------+--------------------------+---------------+-------+-------+--------+--------------+
| ✅ COPYPASTE  | jscpd                    | project       |   n/a |       |      0 |        1.49s |
| ✅ CSS        | stylelint                | list_of_files |     1 |       |      0 |         1.7s |
| ✅ JSON       | eslint-plugin-jsonc      | list_of_files |     2 |       |      0 |         1.6s |
| ✅ JSON       | jsonlint                 | file          |     2 |       |      0 |        0.88s |
| ✅ JSON       | prettier                 | list_of_files |     2 |       |      0 |        0.92s |
| ✅ JSON       | v8r                      | list_of_files |     2 |       |      0 |        5.98s |
| ◬ MARKDOWN    | markdownlint             | list_of_files |    10 |       |      1 |        0.67s |
| ✅ MARKDOWN   | markdown-link-check      | list_of_files |    10 |       |      0 |        9.26s |
| ✅ MARKDOWN   | markdown-table-formatter | list_of_files |    10 |       |      0 |        0.48s |
| ✅ REPOSITORY | devskim                  | project       |   n/a |       |      0 |        1.33s |
| ✅ REPOSITORY | dustilock                | project       |   n/a |       |      0 |        0.01s |
| ✅ REPOSITORY | gitleaks                 | project       |   n/a |       |      0 |        2.41s |
| ✅ REPOSITORY | git_diff                 | project       |   n/a |       |      0 |        0.01s |
| ✅ REPOSITORY | secretlint               | project       |   n/a |       |      0 |        3.78s |
| ❌ REPOSITORY | semgrep                  | project       |   n/a |       |      6 |       75.08s |
| ✅ REPOSITORY | syft                     | project       |   n/a |       |      0 |        6.74s |
::set-output name=has_updated_sources::0
| ❌ REPOSITORY | trivy                    | project       |   n/a |       |      1 |       29.91s |
| ❌ SPELL      | cspell                   | list_of_files |   102 |       |  12944 |      123.06s |
| ✅ SPELL      | misspell                 | list_of_files |   101 |       |      0 |         0.1s |
| ✅ YAML       | prettier                 | list_of_files |     2 |       |      0 |        0.93s |
| ✅ YAML       | v8r                      | list_of_files |     2 |       |      0 |        2.49s |
| ✅ YAML       | yamllint                 | list_of_files |     2 |       |      0 |        0.26s |
+---------------+--------------------------+---------------+-------+-------+--------+--------------+

@nvuillam
Copy link
Member

nvuillam commented Jul 25, 2022

In MegaLinter, spelling linters have a special mode lint_all_other_linters_files ... but also a list of file extensions , including "*" since v6, I don't remember why I added that but it clearly is wrong ^^
I try to fix that in PR #1649

@ThomasRunting
Copy link
Author

i can confirm it is fixed

@nvuillam
Copy link
Member

nvuillam commented Aug 4, 2022

Thanks for your feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants