-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clojure] add cljstyle format tool #2011
Comments
Nice proposition :) Can it take a list of files as arguments ? Would you eventually like to make a PR ? :) |
Thank you
Yes, a specific file or set of files can be passed to
I would be happy to take a look, although it will have to be in a few weeks as I have a pressing deadline for my current employer (and still have some covid symptoms - hence the slow reply) |
@practicalli-john I know what it is... I understand, especially the part with being overloaded by tasks at our non-open-source jobs :) I let this issue open, we'll see who will make the PR first ^^ ( it can also be another contributor ^^ ) |
Add cljstyle to check and fix the format of Clojure code As discussed in oxsecurity#2011
I've started a pull request to add cljstyle, not sure if it is correct as yet. I have only added the |
Add cljstyle to check and fix the format of Clojure code As discussed in oxsecurity#2011
I replied in the PR comments :) |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
Not stale :) |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
* [clojure] Add linter cljstyle Add cljstyle to check and fix the format of Clojure code As discussed in #2011 * auto-generated files All auto-generated files from running `build.sh` * tests: update and extend tests for Clojure linters * Use script installer + manage lint & fix args * Fix clj-style install command * build * New way to install glibc From https://github.com/Docker-Hub-frolvlad/docker-alpine-glibc/blob/master/Dockerfile * Fix dockerfile build * Test folder for cljstyle * Add clojure fix test files * wget --quiet --------- Co-authored-by: nvuillam <nicolas.vuillamy@gmail.com>
Passed :) |
Provide a format tool for the Clojure language linters
Proposal
Add cljstyle to the Clojure language linters with a default configuration that matches the Clojure Style Guide (which it does by default)
cljstyle provides a binary to check and fix Clojure code (.clj, .cljs, .cljc, .edn) and can format code following the Clojure style guide.
cljstyle can be configured via the
.cljstyle
file, so can easily be configured by the end user as well as provide a default configurationcljstyle is available as part of the setup-clojure GitHub Action, so having the same tool in MegaLinter would help with consistency and allowing easy migration path to MegaLinter if desired.
Alternatives
cljfmt is a library cljstyle was based on. cljfmt is not availabe as a binary, so would either require building or uses as a library.
zprint is available as a binary, although it is a more general file formatting tool that requires more understanding to configure. zprint may be a useful addition along with cljstyle, especially if a good default configuration can be defined.
The text was updated successfully, but these errors were encountered: