Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab comment reporter, misleading error message #2420

Closed
LBeaulaton opened this issue Mar 5, 2023 · 3 comments · Fixed by #2421
Closed

gitlab comment reporter, misleading error message #2420

LBeaulaton opened this issue Mar 5, 2023 · 3 comments · Fixed by #2421

Comments

@LBeaulaton
Copy link
Contributor

For gitlab CI, if the access token is badly defined (see the correct way: https://github.com/oxsecurity/megalinter#gitlab-ci), the following line asks for defining GITLAB_MEGALINTER_ACCESS_TOKEN while it should be GITLAB_ACCESS_TOKEN_MEGALINTER

"GITLAB_MEGALINTER_ACCESS_TOKEN containing a personal token with scope 'api'\n"

Note also that in the readme you do not precise that the access token should have the appropriate role (when it is a project token and not a personal token like in the demo) to comment on a merge request (at least developer).

PS: thanks for your great job

@nvuillam
Copy link
Member

nvuillam commented Mar 5, 2023

@LBeaulaton good catch , thanks :)

Would you like to make a quick PR ? :)

@LBeaulaton
Copy link
Contributor Author

never done this, I can try

@nvuillam
Copy link
Member

nvuillam commented Mar 5, 2023

@LBeaulaton contributing to open source is a great experience :) ( be careful, if you're like me, once you'll start you'll never stop :D )

https://megalinter.io/latest/contributing/#submitting-a-pull-request

(as this is a very simple PR you may just fork, update the code and create a PR, no need to locally build )

LBeaulaton added a commit to LBeaulaton/megalinter that referenced this issue Mar 5, 2023
nvuillam added a commit that referenced this issue Mar 7, 2023
* Resolves #2420

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Nicolas Vuillamy <nicolas.vuillamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants