Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are GITLAB_API_URL and GITLAB_SERVER_URL still used? #2423

Closed
LBeaulaton opened this issue Mar 5, 2023 · 1 comment · Fixed by #2424
Closed

Are GITLAB_API_URL and GITLAB_SERVER_URL still used? #2423

LBeaulaton opened this issue Mar 5, 2023 · 1 comment · Fixed by #2424
Labels
question Further information is requested

Comments

@LBeaulaton
Copy link
Contributor

They are referenced in the doc but do not seem to be used (neither in the json descriptor file nor in the gitlab python reporter.

If so this should be deleted in in the doc (I can do this PR if it helps)
@LBeaulaton LBeaulaton added the question Further information is requested label Mar 5, 2023
@nvuillam
Copy link
Member

nvuillam commented Mar 5, 2023

Indeed we use gitlab_server_url = config.get("CI_SERVER_URL", self.gitlab_server_url)

We'll gladly accept your PR :) ( see ? Once you start contributing to open-source you can't stop 🤣 )

LBeaulaton added a commit to LBeaulaton/megalinter that referenced this issue Mar 5, 2023
@LBeaulaton
Resolves oxsecurity#2423
6618f32
@LBeaulaton LBeaulaton mentioned this issue Mar 5, 2023
Merged
4 tasks
nvuillam added a commit that referenced this issue Mar 7, 2023
@LBeaulaton @nvuillam
Clean Gitlab Comment Reporter doc (#2424)
2b77972 
* Resolves #2423

* Update CHANGELOG.md

---------

Co-authored-by: Nicolas Vuillamy <nicolas.vuillamy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean Gitlab Comment Reporter doc LBeaulaton/megalinter
2 participants
@nvuillam @LBeaulaton