Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown-link-check in megalinter ignores .markdown-link-check.json in 6.21.0 #2498

Closed
ruzickap opened this issue Mar 30, 2023 · 2 comments · Fixed by #2501
Closed

markdown-link-check in megalinter ignores .markdown-link-check.json in 6.21.0 #2498

ruzickap opened this issue Mar 30, 2023 · 2 comments · Fixed by #2501
Labels
bug Something isn't working

Comments

@ruzickap
Copy link
Contributor

Describe the bug
I'm using .markdown-link-check.json to configure MegaLinter's markdown-link-check checker.
The configuration file .markdown-link-check.json was used by the markdown-link-check, but something has changed in megalinter 6.21.0 and this config file is ignoerd in this version.

There was some change in the 6.21.0 related to markdown-link-check but I'm not sure if it is relevant: #2479.

To Reproduce
Steps to reproduce the behavior:

Try to create .markdown-link-check.json https://github.com/ruzickap/ruzickap.github.io/blob/main/.markdown-link-check.json which should have some effect and then run with megalinter 6.20.1 vs 6.21.0

Expected behavior

If .markdown-link-check.json file exists then MegaLinter's markdown-link-check checker should used it like if was before 6.21.0 version

@ruzickap ruzickap added the bug Something isn't working label Mar 30, 2023
@Kurt-von-Laven
Copy link
Collaborator

We upgraded markdown-link-check. The root cause is tcort/markdown-link-check#246, but we could drop the version back down until it's fixed given the severity of the bug.

@DariuszPorowski
Copy link
Contributor

issue confirmed, @Kurt-von-Laven pls revert markdown-link-check to 3.10.3

Kurt-von-Laven added a commit that referenced this issue Mar 30, 2023
markdown-link-check config files are ignored at the current latest
version of markdown-link-check, 3.11.0.
nvuillam pushed a commit that referenced this issue Mar 31, 2023
markdown-link-check config files are ignored at the current latest
version of markdown-link-check, 3.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants