Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore symlink files when VALIDATE_ALL_CODEBASE is false #2944

Closed
mcm-ham opened this issue Sep 11, 2023 · 1 comment · Fixed by #2964
Closed

Ignore symlink files when VALIDATE_ALL_CODEBASE is false #2944

mcm-ham opened this issue Sep 11, 2023 · 1 comment · Fixed by #2964
Labels
enhancement New feature or request

Comments

@mcm-ham
Copy link

mcm-ham commented Sep 11, 2023

Is your feature request related to a problem? Please describe.
Currently I get [error] Explicitly specified pattern "<filepath>" is a symbolic link with prettier linter. This happens when VALIDATE_ALL_CODEBASE is false since specific file path is sent to prettier, it doesn't throw error when passing glob path it ignores symlink files silently.

Describe the solution you'd like
I reckon it makes sense to ignore symlink files when VALIDATE_ALL_CODEBASE is false, since original file is modified only that file needs checking not all the symlinked locations since it would be duplicates checks anyway.
@mcm-ham mcm-ham added the enhancement New feature or request label Sep 11, 2023
nvuillam added a commit that referenced this issue Sep 18, 2023
@nvuillam
Exclude symlinks when VALIDATE_ALL_CODEBASE = false
29a5c10 
Fixes #2944
@nvuillam nvuillam mentioned this issue Sep 18, 2023
Merged
@nvuillam
Copy link
Member

@mcm-ham thanks for reporting, PR is on the way :)

nvuillam added a commit that referenced this issue Sep 19, 2023
@nvuillam
Exclude symlinks when VALIDATE_ALL_CODEBASE = false (#2964)
1300aa0 
Fixes #2944
sanmai-NL pushed a commit to sanmai-NL/megalinter that referenced this issue Oct 4, 2023
@nvuillam @sanmai-NL
Exclude symlinks when VALIDATE_ALL_CODEBASE = false (oxsecurity#2964)
62b3fff 
Fixes oxsecurity#2944
@nvuillam nvuillam mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude symlinks when VALIDATE_ALL_CODEBASE = false oxsecurity/megalinter
3 participants
@mcm-ham @nvuillam and others