Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible futur issue with MarkdownLint #3356

Closed
llaville opened this issue Feb 8, 2024 · 4 comments
Closed

Possible futur issue with MarkdownLint #3356

llaville opened this issue Feb 8, 2024 · 4 comments
Labels
question Further information is requested

Comments

@llaville
Copy link
Collaborator

llaville commented Feb 8, 2024

Hello ML team,

I've just upgraded my version of MegaLinter from v6.22.2 to v7.8.0; I know I'm late on migration ;-)

I just got a warning that perharps will become an issue, if we can't check it !

✅ Linted [MARKDOWN] files with [markdownlint]: Found 3 non blocking error(s) - (2.06s)
- Using [markdownlint v0.38.0] https://megalinter.io/7.8.0/descriptors/markdown_markdownlint
- MegaLinter key: [MARKDOWN_MARKDOWNLINT]
- Rules config: [.markdownlint.json]
- Number of files analyzed: [25]
--Error detail:
CHANGELOG-7.x.md:29:54 MD034/no-bare-urls Bare URL used [Context: "https://github.com/nikic/PHP-P..."]
(node:36) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

As MarkdownLint-CLI is installed with NPM, I suppose the node warning came from here.

Just wanted to notify ML team, because I don't have time to check on it !

After fixing error on my repo (CHANGELOG-7.x.md), I re-run ML and got no more error

✅ Linted [MARKDOWN] files with [markdownlint] successfully - (1.52s)
- Using [markdownlint v0.38.0] https://megalinter.io/7.8.0/descriptors/markdown_markdownlint
- MegaLinter key: [MARKDOWN_MARKDOWNLINT]
- Rules config: [.markdownlint.json]
- Number of files analyzed: [25]
@llaville llaville added the question Further information is requested label Feb 8, 2024
@nvuillam
Copy link
Member

nvuillam commented Feb 8, 2024

I don't understand how it can happen... the npm warnings are supposed to happen during installation, not during process :(

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 10, 2024
@nvuillam
Copy link
Member

thanks @llaville (you are also ML team ^^ )

Such warning is the problem of markdownlint-cli... if someday it really doesn't work, MegaLinter auto upgrade jobs will detect it, and either we'll downgrade markdownlint, either they'll provide a fix :)

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 11, 2024
@llaville
Copy link
Collaborator Author

No more error in same context since MegaLinter 7.9.0 ; So I'll close this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants