Remove def.ws prefix from aggregate sarif report #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janderssonse if you update your branch to be up to date with main it should be ok |
janderssonse
force-pushed
the
feature/remove-def-ws-from-aggregate-sarif-report
branch
from
6c3d648
to
e2e2337
Compare
This will replace the default workspace prefix from when creating the aggregate sarif report output. (def. megalinter-reports.sarif). In other words, the artifact uri will be /root/path/of/source/code instead of as of now: DEFAULT_WORKSPACE/root/path/of/source/code. As the DEFAULT_WORKSPACE might only exist during runtime, it needs to be removed. Signed-off-by: Josef Andersson <josef.andersson@gmail.com>
janderssonse
force-pushed
the
feature/remove-def-ws-from-aggregate-sarif-report
branch
from
e2e2337
to
075023b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 82.95% 83.00% +0.05%
==========================================
Files 166 166
Lines 4411 4419 +8
==========================================
+ Hits 3659 3668 +9
+ Misses 752 751 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nvuillam
approved these changes
Dec 19, 2022
janderssonse
deleted the
feature/remove-def-ws-from-aggregate-sarif-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##2006
(partially, see discussion there)
This will replace the default workspace prefix
from when creating the aggregate sarif report output. (def. megalinter-reports.sarif).
In other words, the artifact uri will be
/root/path/of/source/code
instead of as of now:
DEFAULT_WORKSPACE/root/path/of/source/code.
Proposed Changes
As the DEFAULT_WORKSPACE might only exist during
runtime lints, it needs to be removed to offer a deterministic uri, for the reports.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformanceSigned-off-by: Josef Andersson josef.andersson@gmail.com