Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Value for container-name of type String required #2123

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

AlbanAndrieu
Copy link
Contributor

Fixes #

Fix Value for container-name of type String required when running pre-commit run megalinter-incremental

Proposed Changes

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Member

nvuillam commented Dec 7, 2022

I'm a newbie with pre-commit... :D
@Kurt-von-Laven , your opinion ? :)

@AlbanAndrieu
Copy link
Contributor Author

It seems working for me on Ubuntu LTS with node v18.12.1.
I tested it on node, PHP, java, python and devops project.

If some other want workaround :

    rev: v6.15.0
    hooks:
      - id: megalinter-incremental # Faster, less thorough
        args:
          - mega-linter-runner
          - --containername
          - "megalinter-incremental"
          - --remove-container
          - --fix
          - --env
          - "'APPLY_FIXES=all'"
          - --env
          - "'CLEAR_REPORT_FOLDER=true'"
          - --env
          - "'LOG_LEVEL=warning'"
          - --filesonly
        stages:
          - commit

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a leap of faith, you seem to know what you are doing :)

@nvuillam nvuillam merged commit 5cbf1b4 into oxsecurity:main Dec 9, 2022
@AlbanAndrieu
Copy link
Contributor Author

@nvuillam Thanks budy

Copy link
Collaborator

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, although the quotes don't do anything. Did you encounter some issue using the original pre-commit hook? It's possible there are some differences in behavior between platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants