Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone CI generator support + Drone CI docs improvement #2195

Merged
merged 7 commits into from Jan 1, 2023
Merged

Drone CI generator support + Drone CI docs improvement #2195

merged 7 commits into from Jan 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2022

#2047

Fixes #

Proposed Changes

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ghost
Copy link
Author

ghost commented Dec 29, 2022

@nvuillam How do I build and run the mega-linter-runner generator? To test the changes.

@nvuillam
Copy link
Member

nvuillam commented Dec 29, 2022

@nvuillam How do I build and run the mega-linter-runner generator? To test the changes.

@NebulaOnion just call npm link at the root of mega-linter-runner folder

Then call mega-linter-runner --install :)

( you need node.js installed on your computer)

@ghost
Copy link
Author

ghost commented Dec 29, 2022

@nvuillam Okay, It seemed to work. However, some things are still not supported (like fixes) and I don't know how to make the generator not ask for whether the user wants to enable those unsupported features or not.

@ghost ghost marked this pull request as ready for review December 29, 2022 20:51
@ghost ghost requested a review from nvuillam as a code owner December 29, 2022 20:51
@nvuillam
Copy link
Member

Not possible for now, let's hope you or someone find the syntax soon :)
But it won't prevent this PR to get merge, it's a start :)

@codecov-commenter
Copy link

Codecov Report

Merging #2195 (7359afd) into main (7ada2b2) will increase coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
+ Coverage   82.47%   82.99%   +0.51%     
==========================================
  Files         170      170              
  Lines        4469     4469              
==========================================
+ Hits         3686     3709      +23     
+ Misses        783      760      -23     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 89.01% <0.00%> (+8.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 1, 2023

@NebulaOnion apart from the CHANGELOG.md conflict you have to do a rebase with main to solve the trivy error.

@ghost
Copy link
Author

ghost commented Jan 1, 2023

@bdovaz Okay, thanks for the help, I didn't know

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for your contribution :)

@nvuillam nvuillam merged commit 5399d4e into oxsecurity:main Jan 1, 2023
@ghost
Copy link
Author

ghost commented Jan 1, 2023

You're welcome @nvuillam I'm trying to figure out a way to only prompt for currently supported features, but I don't know if I can i'll open a pr if I manage to get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants