Fix local files with extends #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdovaz tips here about quick build and TEST_KEYWORDS, that can dramatically improve CI jobs time when you update just python or doc :) (works only for main repo, not forks) https://megalinter.io/latest/contributing/#cictcd
About the last bullet, for a PR like that I'll merge without requiring it :) |
Codecov Report
@@ Coverage Diff @@
## main #2236 +/- ##
==========================================
+ Coverage 82.48% 82.62% +0.14%
==========================================
Files 170 170
Lines 4470 4484 +14
==========================================
+ Hits 3687 3705 +18
+ Misses 783 779 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @nvuillam By the way, checks validated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #2151 that I made was not right and we didn't realize it because we didn't have tests.
In this PR I add the fix and the tests
@nvuillam check me the tests in case you see that they can be done better because my experience with python is not much and I don't know if the way to build the workspace value is the best.