Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove downgrading of ansible-lint #2257

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Remove downgrading of ansible-lint #2257

merged 4 commits into from
Jan 15, 2023

Conversation

gotit96
Copy link
Contributor

@gotit96 gotit96 commented Jan 13, 2023

Proposed Changes

  1. Remove downgrading of ansible-lint
  2. Update test for latest ansible-lint version
  3. Update ansible-lint url

@nvuillam
Copy link
Member

@gotit96 great PR :)

The failing test case is about this message WARNING: PATH altered to expand ~ in it. Read https://stackoverflow.com/a/44704799/99834 and correct your system configuration. that appears above the SARIF output, so SARIF json is not recognized

Would you know a way to make it disappear ?

nvuillam
nvuillam approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for your contribution :)
I retrofited in your branch a fix about reading SARIF, the remaining error is a false positive ^^

@nvuillam nvuillam merged commit 881b934 into oxsecurity:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gotit96 @nvuillam