WIP: Change the way Azure Devops project #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix issue oxsecurity#2300
|
I was searching, I've a doubt if we can create an Azure DevOps org with a white space.
Many company use space in the project or repo name, maybe it's better to sanatize all, just in case, don't you think so?
…________________________________
From: Kurt von Laven ***@***.***>
Sent: Monday, January 30, 2023 10:01:18 PM
To: oxsecurity/megalinter ***@***.***>
Cc: Etienne Deneuve ***@***.***>; Author ***@***.***>
Subject: Re: [oxsecurity/megalinter] WIP: Change the way Azure Devops project (PR #2301)
@Kurt-von-Laven commented on this pull request.
Should we do the same with SYSYSTEM_COLLECTIONURI?
—
Reply to this email directly, view it on GitHub<#2301 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHWVEPTI7BKQS3TOXZUUPDWVATZ5ANCNFSM6AAAAAAULO3HQU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
By definition, an URI does not need to be encoded / decoded , so if SYSTEM_COLLECTIONURI is a valid URI, it should not be necessary to manipulate it :) |
nvuillam
approved these changes
Jan 30, 2023
|
The megalinter-runner job issue is not related to this PR, that's why I force its merge |
|
And thanks for megalinter and the merge ;)
…________________________________
From: Nicolas Vuillamy ***@***.***>
Sent: Monday, January 30, 2023 10:27:59 PM
To: oxsecurity/megalinter ***@***.***>
Cc: Etienne Deneuve ***@***.***>; Author ***@***.***>
Subject: Re: [oxsecurity/megalinter] WIP: Change the way Azure Devops project (PR #2301)
@nvuillam approved this pull request.
Thanks for the catch and thanks for the PR :)
—
Reply to this email directly, view it on GitHub<#2301 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHWVEMAFYX3CYAK6IN4AX3WVAW57ANCNFSM6AAAAAAULO3HQU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@EtienneDeneuve you're welcome :) Note: ghcr.io seems down, or in bad shape... so the build of beta is currently failing ... when it will be available I'll notify here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue #2300