Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config test #2426

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Improve config test #2426

merged 1 commit into from
Mar 6, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Mar 6, 2023

Context: #2418 (comment)

@bdovaz bdovaz requested a review from nvuillam as a code owner March 6, 2023 09:59
@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.14s
✅ BASH shfmt 6 0 0 0.39s
✅ COPYPASTE jscpd yes no 2.39s
✅ DOCKERFILE hadolint 114 0 15.48s
✅ JSON eslint-plugin-jsonc 21 0 0 2.07s
✅ JSON jsonlint 19 0 0.18s
✅ JSON v8r 21 0 11.88s
⚠️ MARKDOWN markdownlint 309 0 230 6.71s
✅ MARKDOWN markdown-link-check 309 0 5.36s
✅ MARKDOWN markdown-table-formatter 309 0 0 16.01s
✅ OPENAPI spectral 1 0 1.52s
⚠️ PYTHON bandit 183 47 2.03s
✅ PYTHON black 183 0 0 4.65s
✅ PYTHON flake8 183 0 1.91s
✅ PYTHON isort 183 0 0 0.81s
✅ PYTHON mypy 183 0 6.58s
✅ PYTHON pylint 183 0 11.37s
⚠️ PYTHON pyright 183 250 15.59s
✅ REPOSITORY checkov yes no 28.89s
✅ REPOSITORY git_diff yes no 0.41s
✅ REPOSITORY secretlint yes no 12.13s
✅ REPOSITORY trivy yes no 27.0s
✅ SPELL cspell 745 0 18.93s
✅ SPELL misspell 566 0 0 0.93s
✅ XML xmllint 3 0 0 0.41s
✅ YAML prettier 81 0 0 2.91s
✅ YAML v8r 23 0 61.07s
✅ YAML yamllint 82 0 1.11s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bdovaz
Copy link
Collaborator Author

bdovaz commented Mar 6, 2023

@nvuillam do I put the ignore in this branch or do you do it in main?

image

@nvuillam
Copy link
Member

nvuillam commented Mar 6, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.16s
✅ BASH shfmt 6 0 0 0.04s
✅ COPYPASTE jscpd yes no 2.96s
✅ DOCKERFILE hadolint 114 0 14.37s
✅ JSON eslint-plugin-jsonc 21 0 0 1.84s
✅ JSON jsonlint 19 0 0.15s
✅ JSON npm-package-json-lint yes no 0.6s
✅ JSON v8r 21 0 11.9s
⚠️ MARKDOWN markdownlint 309 2 230 5.85s
✅ MARKDOWN markdown-link-check 309 0 5.13s
✅ MARKDOWN markdown-table-formatter 309 2 0 16.0s
✅ OPENAPI spectral 1 0 1.44s
⚠️ PYTHON bandit 183 47 2.2s
✅ PYTHON black 183 0 0 3.33s
✅ PYTHON flake8 183 0 1.82s
✅ PYTHON isort 183 0 0 0.43s
✅ PYTHON mypy 183 0 7.07s
✅ PYTHON pylint 183 0 10.82s
⚠️ PYTHON pyright 183 250 16.05s
✅ REPOSITORY checkov yes no 28.71s
⚠️ REPOSITORY devskim yes 61 1.36s
✅ REPOSITORY dustilock yes no 2.14s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 6.75s
✅ REPOSITORY syft yes no 1.05s
✅ REPOSITORY trivy yes no 23.54s
✅ SPELL cspell 745 0 18.15s
✅ SPELL misspell 566 2 0 0.55s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 81 0 0 2.6s
✅ YAML v8r 23 0 26.18s
✅ YAML yamllint 82 0 1.08s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better indeed :)
trivy issue is fixed in another PR

@nvuillam nvuillam merged commit cc683d0 into main Mar 6, 2023
@nvuillam nvuillam deleted the feature/better-config-test branch March 6, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants