Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] runner - doc fix for env list of values #2449

Merged
merged 5 commits into from
Mar 26, 2023
Merged

[documentation] runner - doc fix for env list of values #2449

merged 5 commits into from
Mar 26, 2023

Conversation

DariuszPorowski
Copy link
Contributor

@DariuszPorowski DariuszPorowski commented Mar 9, 2023 •
edited
Loading

Fixes #2448 based on solution from #1659

Proposed Changes

'ENABLE=MARKDOWN,YAML' -> "'ENABLE=MARKDOWN,YAML'"

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

nvuillam
nvuillam requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)
Please can you check the comment ?

docs/mega-linter-runner.md Show resolved Hide resolved
@DariuszPorowski DariuszPorowski changed the title runner - doc fix for env list of values [documentation] runner - doc fix for env list of values Mar 10, 2023
nvuillam
nvuillam approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR :)

@nvuillam nvuillam merged commit 65d3ca4 into oxsecurity:main Mar 26, 2023
@DariuszPorowski DariuszPorowski mentioned this pull request Apr 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to pass array of values for envs with local runner (cli)
2 participants
@DariuszPorowski @nvuillam