Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement & fixes for GitlabCommentReporter #2564

Merged
merged 4 commits into from
Apr 16, 2023
Merged

Conversation

nvuillam
Copy link
Member

  • New var GITLAB_COMMENT_REPORTER_OVERWRITE_COMMENT to allow to disable the overwrite of existing MegaLinter comment in case of new run
  • In case of overwrite activated (by default), fetch all Merge Request comments, not the first 20.
  • Display a different message in log when a Merge Request comment is created or updated.

Fixes #2561

    - New var GITLAB_COMMENT_REPORTER_OVERWRITE_COMMENT to allow to disable the overwrite of existing MegaLinter comment in case of new run
    - In case of overwrite activated (by default), fetch all Merge Request comments, not the first 20.
    - Display a different message in log when a Merge Request comment is created or updated.
@nvuillam
Copy link
Member Author

nvuillam commented Apr 15, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.02s
✅ BASH shellcheck 6 0 0.17s
✅ BASH shfmt 6 0 0 0.44s
✅ COPYPASTE jscpd yes no 3.82s
✅ DOCKERFILE hadolint 116 0 22.92s
✅ JSON eslint-plugin-jsonc 21 0 0 2.8s
✅ JSON jsonlint 19 0 0.24s
✅ JSON v8r 21 0 17.11s
⚠️ MARKDOWN markdownlint 312 0 230 8.29s
✅ MARKDOWN markdown-link-check 312 0 6.36s
✅ MARKDOWN markdown-table-formatter 312 0 0 24.93s
✅ OPENAPI spectral 1 0 1.9s
⚠️ PYTHON bandit 186 57 2.73s
✅ PYTHON black 186 0 0 5.38s
✅ PYTHON flake8 186 0 2.28s
✅ PYTHON isort 186 0 0 1.07s
✅ PYTHON mypy 186 0 10.85s
✅ PYTHON pylint 186 0 16.29s
⚠️ PYTHON pyright 186 251 21.81s
✅ PYTHON ruff 186 0 0 0.5s
✅ REPOSITORY checkov yes no 42.14s
✅ REPOSITORY git_diff yes no 0.48s
✅ REPOSITORY secretlint yes no 17.14s
✅ REPOSITORY trivy yes no 39.54s
✅ SPELL cspell 754 0 32.25s
✅ SPELL misspell 573 0 0 1.33s
✅ XML xmllint 3 0 0 0.48s
✅ YAML prettier 81 0 0 3.71s
✅ YAML v8r 23 0 71.15s
✅ YAML yamllint 82 0 1.58s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Member Author

nvuillam commented Apr 15, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.05s
✅ BASH shellcheck 6 0 0.15s
✅ BASH shfmt 6 0 0 0.04s
✅ COPYPASTE jscpd yes no 3.57s
✅ DOCKERFILE hadolint 116 0 16.98s
✅ JSON eslint-plugin-jsonc 21 0 0 2.13s
✅ JSON jsonlint 19 0 0.17s
✅ JSON npm-package-json-lint yes no 0.94s
✅ JSON v8r 21 0 14.66s
⚠️ MARKDOWN markdownlint 312 0 230 7.0s
✅ MARKDOWN markdown-link-check 312 0 6.17s
✅ MARKDOWN markdown-table-formatter 312 0 0 21.98s
✅ OPENAPI spectral 1 0 1.59s
⚠️ PYTHON bandit 186 57 2.41s
✅ PYTHON black 186 0 0 3.99s
✅ PYTHON flake8 186 0 2.1s
✅ PYTHON isort 186 0 0 0.53s
✅ PYTHON mypy 186 0 8.32s
✅ PYTHON pylint 186 0 13.26s
⚠️ PYTHON pyright 186 251 18.98s
✅ PYTHON ruff 186 0 0 0.11s
✅ REPOSITORY checkov yes no 36.51s
⚠️ REPOSITORY devskim yes 61 1.4s
✅ REPOSITORY dustilock yes no 2.14s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 9.23s
✅ REPOSITORY syft yes no 0.9s
✅ REPOSITORY trivy yes no 25.08s
✅ SPELL cspell 754 0 22.94s
✅ SPELL misspell 573 0 0 0.6s
✅ XML xmllint 3 0 0 0.03s
✅ YAML prettier 81 0 0 2.93s
✅ YAML v8r 23 0 66.64s
✅ YAML yamllint 82 0 1.35s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit a45c808 into main Apr 16, 2023
@nvuillam nvuillam deleted the feature/gitlab-reporter branch April 16, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab Reporter - error on multiple pipeline run
1 participant