Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bitbucket template + Fix icon in console logs #2617

Merged
merged 8 commits into from May 15, 2023

Conversation

Doommius
Copy link
Contributor

@Doommius Doommius commented May 5, 2023

Fixes #1324

Updates doc with template for bitbucket pipeline.

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@Doommius Doommius requested a review from nvuillam as a code owner May 5, 2023 11:32
@Doommius
Copy link
Contributor Author

Doommius commented May 5, 2023

Also added a fix for the console reporter where it used the incorrect char, This might break some outside if people manually added a fix to use the correct char.

image

@nvuillam
Copy link
Member

nvuillam commented May 6, 2023

Nice :)
CI is currently broken but I'm working to solve it, I'll merge your PR jsut after :)

@nvuillam
Copy link
Member

nvuillam commented May 6, 2023

Also added a fix for the console reporter where it used the incorrect char, This might break some outside if people manually added a fix to use the correct char.

image

MegaLinter can output many formats, including JSON and SARIF, this table is not supposed to be parsed, so for me it's ok, nice enhancement :)

But you can specify it by updating CHANGELOG.md , in that case people who would have issues could see why in the release notes :)

@nvuillam
Copy link
Member

@Doommius please can you merge main into your branch ? CI is repaired :)

Also: installation.md is generated from README.md, please can you update the README to add bitbucket instructions ? :)

@nvuillam nvuillam changed the title added bitbucket template Added bitbucket template + Fix icon in console logs May 15, 2023
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Doommius for this PR and for sharing with the community the recipe to use MegaLinter on Bitbucket pipelines :)

@nvuillam nvuillam merged commit 4ff38ce into oxsecurity:main May 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitbucket Pipeline Support
2 participants