Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted config files to not fail common linters (closes #2890) #2891

Merged
merged 1 commit into from Aug 17, 2023

Conversation

andrewvaughan
Copy link
Contributor

Fixes #2890

Important - I am still unable to run tests locally, so a solid code-review would be very-much appreciated.

Additionally, I believe that the change of the job name from build to megalinter - while extremely important for people who build automation scripts that reference the build name (like myself) and need something more specific than "build", this may end up being a breaking change if anyone has built such scripts or dependencies in the past. Please keep this in mind for release policies.

Proposed Changes

  1. Used more-advanced YAML to better-format config files so they don't fail with common linters (especially those that enforce line-length)
  2. Changed the workflow job name from a generic build which can conflict with other workflows to megalinter

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@andrewvaughan andrewvaughan temporarily deployed to dev August 17, 2023 18:11 — with GitHub Actions Inactive
@andrewvaughan andrewvaughan temporarily deployed to dev August 17, 2023 18:11 — with GitHub Actions Inactive
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for your contribution :)

@nvuillam nvuillam merged commit bf09afc into oxsecurity:main Aug 17, 2023
7 checks passed
@nvuillam
Copy link
Member

@andrewvaughan it would reassure me if you can test a little with npx mega-linter-runner@beta --install before we release a new version :) ( otherwise I'll test it myself but I have some time availability issues these days ^^ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated workflow file fails most default linting tools
2 participants