Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: config-cli-lint-mode.md: Grammar tweaks #2953

Merged
merged 4 commits into from Sep 20, 2023
Merged

docs: config-cli-lint-mode.md: Grammar tweaks #2953

merged 4 commits into from Sep 20, 2023

Conversation

rasa
Copy link
Contributor

@rasa rasa commented Sep 13, 2023

Please accept, or reject, as you see fit.

@rasa rasa requested a review from nvuillam as a code owner September 13, 2023 00:28
@rasa rasa temporarily deployed to dev September 13, 2023 00:28 — with GitHub Actions Inactive
@rasa rasa temporarily deployed to dev September 13, 2023 00:29 — with GitHub Actions Inactive
Kurt-von-Laven
Kurt-von-Laven requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements.

docs/config-cli-lint-mode.md Outdated Show resolved Hide resolved
docs/config-cli-lint-mode.md Outdated Show resolved Hide resolved
docs/config-cli-lint-mode.md Outdated Show resolved Hide resolved
docs/config-cli-lint-mode.md Outdated Show resolved Hide resolved
docs/config-cli-lint-mode.md Outdated Show resolved Hide resolved
@rasa rasa temporarily deployed to dev September 14, 2023 15:56 — with GitHub Actions Inactive
@nvuillam
Copy link
Member

nvuillam commented Sep 18, 2023 •
edited

@rasa I'd love to accept the PR (I have no issue to admit that my french-english is clumsy 🤣 ), but please can you put the updates in README.me ?

config-cli-lint-mode.md is automatically generated from it :)

@rasa rasa temporarily deployed to dev September 20, 2023 05:13 — with GitHub Actions Inactive
@rasa rasa temporarily deployed to dev September 20, 2023 05:13 — with GitHub Actions Inactive
nvuillam
nvuillam approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is a critical part of Open Source projects, so many thanks for this clarifications :)

@nvuillam nvuillam merged commit 3ab9a1e into oxsecurity:main Sep 20, 2023
7 checks passed
sanmai-NL pushed a commit to sanmai-NL/megalinter that referenced this pull request Oct 4, 2023
@rasa @Kurt-von-Laven @sanmai-NL
docs: config-cli-lint-mode.md: Grammar tweaks (oxsecurity#2953)
f30c6fc 
* docs: config-cli-lint-mode.md: Grammar tweaks

* Update config-cli-lint-mode.md per review comments

See oxsecurity#2953 (review)

* Update README.md

* Update README.md

Co-authored-by: Kurt von Laven <974910+Kurt-von-Laven@users.noreply.github.com>
@nvuillam nvuillam mentioned this pull request Oct 5, 2023
Closed
@rasa rasa deleted the patch-1 branch October 22, 2023 06:36
@rasa rasa restored the patch-1 branch October 22, 2023 06:36
@rasa rasa deleted the patch-1 branch October 22, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kurt-von-Laven Kurt-von-Laven Kurt-von-Laven requested changes

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rasa @nvuillam @Kurt-von-Laven