Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the other maintainers globally to the CODEOWNERS file #3008

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Oct 14, 2023

Proposed Changes

  1. Adds the other maintainers as code owners for the global rule, so they can also approve PRs.
  2. Adds a little more explanation comments to the file.
  3. Following GitHub's documentation, place the global rule above, and the exceptions below, since the last matching pattern takes precedence.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@github-actions
Copy link
Contributor

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.1s
✅ BASH shfmt 5 0 0 0.43s
✅ COPYPASTE jscpd yes no 3.58s
✅ DOCKERFILE hadolint 123 0 16.66s
✅ JSON eslint-plugin-jsonc 23 0 0 2.34s
✅ JSON jsonlint 21 0 0.22s
✅ JSON v8r 23 0 14.21s
✅ MAKEFILE checkmake 1 0 0.0s
⚠️ MARKDOWN markdownlint 255 0 11 5.63s
✅ MARKDOWN markdown-link-check 255 0 5.34s
✅ MARKDOWN markdown-table-formatter 255 0 0 29.86s
✅ OPENAPI spectral 1 0 1.4s
⚠️ PYTHON bandit 200 61 2.39s
✅ PYTHON black 200 0 0 4.72s
✅ PYTHON flake8 200 0 1.99s
✅ PYTHON isort 200 0 0 0.83s
✅ PYTHON mypy 200 0 10.65s
✅ PYTHON pylint 200 0 12.65s
⚠️ PYTHON pyright 200 362 20.71s
✅ PYTHON ruff 200 0 0 0.48s
✅ REPOSITORY checkov yes no 34.29s
✅ REPOSITORY git_diff yes no 0.42s
⚠️ REPOSITORY grype yes 1 11.5s
✅ REPOSITORY secretlint yes no 7.92s
✅ REPOSITORY trivy yes no 24.72s
✅ REPOSITORY trivy-sbom yes no 1.05s
⚠️ REPOSITORY trufflehog yes 1 23.89s
✅ SPELL cspell 665 0 22.9s
❌ SPELL lychee 335 1 5.53s
✅ XML xmllint 3 0 0 0.43s
✅ YAML prettier 160 0 0 4.59s
✅ YAML v8r 102 0 170.39s
✅ YAML yamllint 161 0 1.63s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix echoix temporarily deployed to dev October 14, 2023 16:19 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev October 14, 2023 16:19 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev October 14, 2023 16:19 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev October 14, 2023 16:19 — with GitHub Actions Inactive
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echoix :)

@nvuillam nvuillam merged commit b024017 into main Oct 14, 2023
123 of 125 checks passed
@nvuillam nvuillam deleted the add-maintainers-to-codeowners branch October 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants