Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devcontainer Dockerfile typo (fixes #3114) #3115

Merged
merged 6 commits into from Nov 18, 2023
Merged

Fix devcontainer Dockerfile typo (fixes #3114) #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9773b0
Fix devcontainer Dockerfile typo (fixes #3114)
daltonv Nov 14, 2023
75beaed
Merge branch 'main' into dv_devcontainer_build
echoix Nov 15, 2023
a3bb841
Remove outdated comment from devcontainer Dockerfile
daltonv Nov 15, 2023
c20e5be
Merge branch 'main' into dv_devcontainer_build
daltonv Nov 15, 2023
dc723a7
Merge branch 'main' into dv_devcontainer_build
nvuillam Nov 18, 2023
50bb213
Merge branch 'main' into dv_devcontainer_build
echoix Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .devcontainer/Dockerfile
View file
Open in desktop
Expand Up @@ -8,9 +8,8 @@ FROM mcr.microsoft.com/vscode/devcontainers/python:0-${VARIANT}
ARG NODE_VERSION="16"
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi

# [Optional] If your pip requirements rarely change, uncomment this section to add them to the image.
COPY .config/python/dev/requirements.txt /tmp/pip-tmp/
RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.dev.txt \
RUN pip3 --disable-pip-version-check --no-cache-dir install -r /tmp/pip-tmp/requirements.txt \
&& rm -rf /tmp/pip-tmp

RUN npm install markdown-table-formatter -g
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-l
- Update lintr links to their current locations, by @echoix in [#3122](https://github.com/oxsecurity/megalinter/issues/3122)
- Update Pylint links to their current locations, by @echoix in [#3116](https://github.com/oxsecurity/megalinter/issues/3116)
- Fix way to install powershell on Alpine linux image

- Fix issue with VS Code devcontainer not building [#3114](https://github.com/oxsecurity/megalinter/issues/3114)

- CI
- Upgrade pymdown-extensions and markdown, by @BryanQuigley in [#3053](https://github.com/oxsecurity/megalinter/pull/3053)
Expand Down