Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move checkov output to REPORT_FOLDER #3121

Merged
merged 6 commits into from Nov 18, 2023

Conversation

gmeligio
Copy link
Contributor

@gmeligio gmeligio commented Nov 15, 2023

Proposed Changes

  1. Write checkov SARIF report in REPORT_FOLDER instead of DEFAULT_WORKSPACE, removing the need of adding the generated results.sarif to .gitignore when running megalinter locally.
  2. When passing --output-file-path, checkov automatically changes the report file name from results.sarif to results_sarif.sarif.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot for your contribution @gmeligio :)

@nvuillam nvuillam merged commit c7a38b5 into oxsecurity:main Nov 18, 2023
6 checks passed
@gmeligio
Copy link
Contributor Author

Thank you for the review @nvuillam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants