Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powershell installation #3126

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Fix powershell installation #3126

merged 2 commits into from
Nov 18, 2023

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Nov 18, 2023

Copy link
Contributor

github-actions bot commented Nov 18, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 5 0 0.1s
✅ BASH shellcheck 5 0 0.17s
✅ BASH shfmt 5 0 0 0.07s
✅ COPYPASTE jscpd yes no 4.12s
✅ DOCKERFILE hadolint 124 0 14.84s
✅ JSON eslint-plugin-jsonc 23 0 0 3.39s
✅ JSON jsonlint 21 0 0.31s
✅ JSON v8r 23 0 18.87s
✅ MAKEFILE checkmake 1 0 0.03s
⚠️ MARKDOWN markdownlint 256 0 11 7.13s
✅ MARKDOWN markdown-link-check 256 0 8.07s
✅ MARKDOWN markdown-table-formatter 256 0 0 52.34s
✅ OPENAPI spectral 1 0 1.91s
⚠️ PYTHON bandit 201 61 5.89s
✅ PYTHON black 201 0 0 4.2s
✅ PYTHON flake8 201 0 2.71s
✅ PYTHON isort 201 0 0 0.71s
✅ PYTHON mypy 201 0 14.89s
✅ PYTHON pylint 201 0 16.73s
⚠️ PYTHON pyright 201 342 24.91s
✅ PYTHON ruff 201 0 0 0.14s
✅ REPOSITORY checkov yes no 39.35s
✅ REPOSITORY git_diff yes no 0.06s
⚠️ REPOSITORY grype yes 1 25.31s
✅ REPOSITORY secretlint yes no 11.43s
✅ REPOSITORY trivy yes no 40.11s
✅ REPOSITORY trivy-sbom yes no 20.26s
⚠️ REPOSITORY trufflehog yes 1 17.94s
✅ SPELL cspell 668 0 31.49s
✅ SPELL lychee 336 0 5.22s
✅ XML xmllint 3 0 0 0.06s
✅ YAML prettier 160 0 0 7.64s
✅ YAML v8r 102 0 154.33s
✅ YAML yamllint 161 0 2.16s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit bda43ba into main Nov 18, 2023
127 checks passed
@nvuillam nvuillam deleted the fixes/powershell-install branch November 18, 2023 18:47
@bdovaz
Copy link
Collaborator

bdovaz commented Jan 4, 2024

@nvuillam why did you change the installation mode? The previous one (using API) allowed us to automatically reference "latest", now it is not possible and we have to change it manually, i.e. now it is more expensive to keep powershell updated because it is spread over several different descriptors.

cc: @echoix @Kurt-von-Laven

@echoix
Copy link
Collaborator

echoix commented Jan 4, 2024

I don't think it's that problematic, it's the official download instructions, we don't use up another api request (we are sometimes hitting some limits), and it's quite the standard way we download from github releases anyways. Since the version is pinned in the powershell descriptor, there's only one place anyway to change anyway, and at least the builds are kinda reproducible.

@nvuillam
Copy link
Member Author

nvuillam commented Jan 7, 2024

Usually when i do an update like that it's because Auto-update-linters job is failing with its current instructions , that probably was the case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants