mega-linter-runner: Improve check if running as script or module

[echoix]

Apparently the check for using the command line arguments to create the MegaLinterRunnerCli() when run as a script wasn’t working correctly since changed to use modules, at least in tests. That meant that all command line arguments (of the test invocation) were passed when the tests for modules was used (since called before), and since the no docker pull option isn’t in the argv of the mocha invocation, it pulled the latest Megalinter docker image (a second one) and started to lint the workspace instead of just doing the tests.

Here, the argv is really only passed when it is called a script and not a module.

Proposed Changes

1. …
2. …
3. …

Readiness Checklist

Author/Contributor

• Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[echoix]

Since the mega-linter-runner tests at the end of the build and deploy dev workflow doesn’t have to waste time pulling, the time is down to 2min22 seconds for this step, instead of the 6min30 sec that was taken.

In the tests, it’s the v8r linter that seems way too slow (40 secs instead of less than 2 for the other 2 linters)

[nvuillam]

Seems ok :)
Please test with mega-linter-runner@beta before our next release :)