Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs in readme #14

Closed
liyang619 opened this issue Feb 24, 2023 · 2 comments
Closed

Some bugs in readme #14

liyang619 opened this issue Feb 24, 2023 · 2 comments

Comments

@liyang619
Copy link

Hi, I find some problems in your readme, which may confuse us.

  1. In the "capability config" and code example", the item ""n_enemies": 5 " shouldn't be under strat_positions, it is should be closed to "n_unit".
  2. it imports from smac in the example code, you should import from smacv2?

Besides, which version of pettingzoo do you use? I cannot run the example code of pettingzoo, which raises error "ImportError: cannot import name 'from_parallel_wrapper' from 'pettingzoo.utils.conversions'".

@benellis3
Copy link
Collaborator

Thanks very much for the feedback on the readme, that's very useful! I will make some edits to that tomorrow.

On PettingZoo, I haven't tested the pettingzoo wrapper so currently do not know whether it works. Let me know if it breaks and I will have a quick look at getting it to work -- it shouldn't be too bad hopefully. @mingfeisun in another thread says 1.8.1 should be the version of pettingzoo that is used.

@liyang619
Copy link
Author

Thanks. The 1.8.1 works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants