Skip to content
This repository has been archived by the owner on Aug 17, 2022. It is now read-only.

Remove unreachable code #117

Merged
merged 1 commit into from Jun 25, 2018
Merged

Remove unreachable code #117

merged 1 commit into from Jun 25, 2018

Conversation

steveklabnik
Copy link

This panic can never occur, so putting it here isn't useful.

This panic can never occur, so putting it here isn't useful.
@jennamagius
Copy link
Contributor

Yeah, I put that there on purpose, because it's kinda non-local that std::process::exit() has return type !. But then since then I've used std::process::exit() in many, many more places without this extra explicitness, so may-as-well just normalize.

My fuzzy memory suggests that there's one or two more explicit panics after a -> ! function somewhere in this code base.

@jennamagius jennamagius changed the base branch from master to dev June 25, 2018 20:33
@jennamagius jennamagius merged commit 7dc52c5 into oxy-secure:dev Jun 25, 2018
@steveklabnik
Copy link
Author

Cool cool, makes sense :)

@steveklabnik steveklabnik deleted the patch-1 branch June 25, 2018 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants