Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation/hebrew #165

Merged
merged 12 commits into from Apr 6, 2021
Merged

Translation/hebrew #165

merged 12 commits into from Apr 6, 2021

Conversation

HypeGameMode
Copy link
Contributor

What's changed?

  • V1.0 of Hebrew translate for Oxygen Updater
  • Most of the translation is for both male and female (In Israel there is Different syntax for male and female)
  • 99.9% of the text is translated to Hebrew

Notes:
I need you to send me a APK file from this Hebrew translate, I tried to do this by myself but from some reason i can't see that the language is update. (Like when i choose Hebrew, all the texts are still on English).
Because this translate is not done, there are still a lot to do, to improve this, And i really need to see this on preview.
Thanks Ahead

@adhirajsinghchauhan adhirajsinghchauhan added the translation Translation in an existing or a new language label Apr 1, 2021
adhirajsinghchauhan
adhirajsinghchauhan requested changes Apr 1, 2021
View reviewed changes
Copy link
Member

@adhirajsinghchauhan adhirajsinghchauhan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I'm marking this PR as a draft, because as you said some things are still pending.

Whenever you're comfortable with the translation quality, you can remove the draft status on this PR, which will let us know it's ready to merge into master. We'll send APKs to you over Discord itself.

app/src/main/res/values-he/strings.xml Outdated Show resolved Hide resolved
@adhirajsinghchauhan adhirajsinghchauhan marked this pull request as draft April 1, 2021 04:35
@HypeGameMode
Copy link
Contributor Author

Hi, as i said on discord.
After a while i got a bug that when the language of the app is Hebrew and advanced mode is off the app crashes.
I sent you the updated xml file so you could check it and maybe fix it.
Thanks.

@HypeGameMode HypeGameMode marked this pull request as ready for review April 3, 2021 00:35
@adhirajsinghchauhan
Fixed crash due to incorrect Hebrew translation strings
ea82cc5
@adhirajsinghchauhan
Renamed values-he to values-iw
e91df6b 
"iw" is the old ISO-639 language code for Hebrew, and "he" is the new one. But Android's `java.util.Locale` doesn't properly normalize old codes to new codes. The constructor accepts both old and new, but all other methods return old codes (for backward compatibility reasons I assume).

For posterity, here are the three language codes that `Locale`'s constructor has always adjusted:
iw -> he (Hebrew)
ji -> yi (Yiddish)
in -> id (Indonesian)
@adhirajsinghchauhan adhirajsinghchauhan marked this pull request as draft April 5, 2021 15:50
@HypeGameMode
Copy link
Contributor Author

After working of almost week, I think the translation is good for public.
I have discussed with a lot of people to make this translation as good as possible.
And i think it's enough for now to go for public.

@HypeGameMode HypeGameMode marked this pull request as ready for review April 6, 2021 07:11
@HypeGameMode
Copy link
Contributor Author

HypeGameMode commented Apr 6, 2021 •
edited

1 Line has been fixed

@adhirajsinghchauhan adhirajsinghchauhan merged commit fca4659 into oxygen-updater:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhirajsinghchauhan adhirajsinghchauhan adhirajsinghchauhan approved these changes

Assignees
No one assigned
Labels
translation Translation in an existing or a new language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HypeGameMode @adhirajsinghchauhan