Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC scope configuration key name mismatch #109

Closed
kjoconnor opened this issue Nov 9, 2020 · 4 comments
Closed

OIDC scope configuration key name mismatch #109

kjoconnor opened this issue Nov 9, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@kjoconnor
Copy link

Describe the bug
The documentation as well as the helm chart differ from the source code in regards to OIDC scope specification.

To Reproduce
Configure an OIDC provider:

authProviders:
  oidc:
    provider1:
      scopes:
        - openid
        - email
        - profile
        - groups

Browse to s3-proxy unauthenticated and you will be redirected to the OIDC provider, but it will only have requested the default scopes of [ openid, email, profile ], it will not have added groups.

Expected behavior
I would expect all of the scopes I requested be added to the auth request to the OIDC provider.

Version and platform (please complete the following information):
Running on k8s 1.19 on IBM Cloud, with the latest helm chart and s3-proxy image.

Additional context
It seems to just be a mismatch between the documentation as well as helm chart and the code. The docs and helm chart say to use scopes, but the code itself uses scope. Not sure which direction you prefer to change it.

@kjoconnor kjoconnor added the bug Something isn't working label Nov 9, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.77. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@oxyno-zeta oxyno-zeta self-assigned this Nov 9, 2020
@oxyno-zeta
Copy link
Owner

Hello @kjoconnor

Thanks for your issue. You are right. It is clearly a bug. I will fix it now.
It will be "scopes".

oxyno-zeta added a commit that referenced this issue Nov 9, 2020
@oxyno-zeta
Copy link
Owner

oxyno-zeta commented Nov 9, 2020

A new release has been done with the fix: v3.0.4 . Should be ok now.

@kjoconnor
Copy link
Author

Thank you for the quick fix!

iskandar pushed a commit to iskandar/s3-proxy that referenced this issue Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants