-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy pre-compressed data as-is #358
Comments
Hello @aukaost , Happy to see that this project is interesting for multiple people ;) I'm afraid that this coming from your browser when you download the file. I've already seen this when I used the real S3 interface. Oxyno-zeta |
I'll add some more detail :) |
Interesting... I will need a bit of time to debug this. But thanks for all those details ! |
I'll also have a look, just wanted to check if I was missing anything before I do! |
aws/aws-sdk-go#1292 (comment)
Tested s3-proxy with this modification and that seems to do the job.
|
Thanks for your input and tests ! Now that we know how to patch it, I need to think about a way to add configuration to allow people sending whatever they want :) . |
@aukaost I spend few hours to develop the feature and I was on the test phase and can't reproduce your problem... With this example:
Making those requests:
So... Seems that everything is intact. Am I missing something ? Can you give me a procedure, a configuration and the version you are using please ? |
Ahhh that explains why I wasn't able to reproduce it. Now I am ! And I'm able to make it work as desired too. In all cases, I will probably release early next week. |
That's really awesome, thanks for that :) |
I've tested to switch to Minio for tests but it will required more work than expected... I've decided to release as is the code. 4.9.0 is released with your needed patch ! 🎉 Have a good rest of your day, Oxyno-zeta |
Works like a charm, thanks a lot! |
@aukaost I'm very happy to see that and you are welcome! Do not hesitate if you see a bug or a new feature idea. |
Hi,
Thanks for this project!
If you take a file which is gzipped and has Content-Encoding set to gzip on the object's meta data it seems to be served uncompressed.
Is it possible to proxy those objects as-is?
Thanks!
The text was updated successfully, but these errors were encountered: