Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for rendering issue with doji candles #623 #1246

Closed
wants to merge 1 commit into from

Conversation

lauxjpn
Copy link
Contributor

@lauxjpn lauxjpn commented Oct 13, 2018

Workaround for rendering issue with doji candles (candles with bodies so small, they are just represented by a line). It seems that WPF falsely renders these rectangles with their left coordinates adjusted to the left by the rectangles width (which effectively draws a line double it's intended size). In these edge cases, let's just draw a line (or two) instead of a polygon.

This issue was addressed here:
https://stackoverflow.com/questions/33130300/oxyplot-candle-overlap-each-candle

It might also fix #623 (hard to tell, because the images of the issue are missing).

Before the fix:
doji-before

After the fix:
doji-after

Checklist

  • [y] I have included examples or tests
  • [y] I have updated the change log
  • [y] I am listed in the CONTRIBUTORS file
  • [y] I have cleaned up the commit history (use rebase and squash)

@oxyplot/admins

… so small, they are just represented by a line). It seems that WPF falsely renders these rectangles with their left coordinates adjusted to the left by the rectangles width (which makes effectively draws a line double it's intended size). In these edge cases, let's just draw a line instead of a polygon.
@lauxjpn
Copy link
Contributor Author

lauxjpn commented Oct 13, 2018

Just saw a brand new reported issue regarding this fix, but in the other series:

CandleStick is overlapped when item.open == item.close in the CandleStickAndVolumeSeries #1245

@lauxjpn lauxjpn changed the title Workaround for rendering issue with doji candles Workaround for rendering issue with doji candles #623 Oct 13, 2018
@lauxjpn lauxjpn mentioned this pull request Oct 13, 2018
@lauxjpn
Copy link
Contributor Author

lauxjpn commented Oct 13, 2018

I provided a new pull request, that contains both fixes: #1247
The current pull request can be disregarded.

@lauxjpn lauxjpn closed this Oct 14, 2018
@lauxjpn lauxjpn deleted the fix_issue_623 branch October 14, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Candle overlap each candle
1 participant