-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WPF PlotView based on SkiaSharp (#1515) #1533
Conversation
I think we should be consistent with signing. |
Ah I wasn't aware that you could use the same .snk for multiple assemblies. As far as I can tell so far every assembly has its own .snk file. So if we share the .snk between some of the projects, should we share it between all of them to be consistent? For now I will just copy the .snk files to sign each of the new projects, but that might be something to be considered in a separate issue. |
This seems to introduce a bug into the Wpf example browser, whereby it will crash if you:
Partial stack-trace:
This appears to be new as of 458de6a Everything seems to work fine if I just wrap all of |
Could this be included, but only enabled for the Canvas renderer? |
Good catch! I've addressed it and will upload a fix and test soon.
In principle yes, but I did not found a quick way of getting it to work consistently. |
Squashed the commits. |
Nice! I am looking forward to try this out! |
Fixes #1515.
Checklist
Changes proposed in this pull request:
SkiaRenderContext
OxyPlot.Wpf
andOxyPlot.SkiaSharp.Wpf
, introduceOxyPlot.Wpf.Shared
. Most of the code fromOxyPlot.Wpf
ended up in here.Notes
OxyPlot.SkiaSharp
,OxyPlot.SkiaSharp.Wpf
,OxyPlot.Wpf.Shared
) be signed? @objorke do you want to create the .snk files for those?@oxyplot/admins