Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused LabelColor property (#2030) #2031

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Remove unused LabelColor property (#2030) #2031

merged 1 commit into from
Aug 16, 2023

Conversation

VisualMelon
Copy link
Contributor

@VisualMelon VisualMelon commented Aug 11, 2023 •
edited
Loading

Fixes #2030 .

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Remove Unused LabelColor property from TornadoBarSeries, IntervalBarSeries, and RectangleBarSeries

This is a breaking change. Users expecting this property should use the TextColor.

@oxyplot/admins

@Jonarw
Copy link
Member

Jonarw commented Aug 16, 2023

Requires a rebase after merging #2028 (should be trivial).

@VisualMelon
Copy link
Contributor Author

Rebased

@Jonarw Jonarw merged commit 85dd07d into oxyplot:develop Aug 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonarw Jonarw Jonarw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LabelColor doesn't do anything in TornadoBarSeries and IntervalBarSeries
2 participants
@VisualMelon @Jonarw