Issue #338: Attaching/detaching PlotView/Model in Model setter. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. (same logic as other platforms have in OnModelChanged)
objorke
pushed a commit
that referenced
this pull request
Jan 23, 2015
Issue #338: Attaching/detaching PlotView/Model in Model setter.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to iOS/Android the same logic as other platforms have in OnModelChanged.
(kept to setters since the separate OnModelChanged isn't required here like it is on the DependencyProperty-based implementations, but it could easily be refactored for consistency)
Should also address issue #288.
Warning: I do not have an Android license, so am unable to test that. I am merely trusting that it works there since the same logic is tested on all the other platforms and isn't really platform-specific. (and I have seen this issue discussed in Xamarin's Android forums)