-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert or replace async #26
Conversation
I"m still following the updates, if any, after verifying all code. But i'm pretty happy with the performance stability and concurrency of my version, after specifying some new options i've not pulled yet. Of course it is still not a real IQueryable, which is likely what any of us would like to have. |
This looks good except for one thing; reordering the methods is not OK. |
What do you mean by reordering ? Changing the line at which a method starts ? |
Alright, I'll change the order back and resubmit. :) |
Thanks |
So I reverted |
I'm sorry, but you need to squash these, the problem now is that this history is not very nice to merge into master, and anyone that has forks/branches based on this with changes in the places you've touched will have conflicts when rebasing. |
Well that was painful, but they're all squashed now. |
Thank you, I am almost happy now. Please forgive my pedantic behavior here, I just think these kinds of things are very important for open projects as it can quickly become a huge mess otherwise. |
… following functions (and their corresponding unit tests): - SQLiteConnection.InsertOrReplaceAll() - SQLiteAsyncConnection.InsertOrReplaceAsync() - SQLiteAsyncConnection.InsertOrReplaceAllAsync() This single commit was previously several commits that were pushed to a branch on my fork, but have since been squashed for history/rebase purposes. The squashed commits were: [67db56c] Reverting method reordering, readding SQLiteConnection.InsertOrReplaceAll() methods. [0499a32] Adding unit tests for new InsertOrReplace() and InsertOrReplaceAll() methods. [d5dd60b] Adding SQLiteConnection.InsertOrReplaceAll() and SQLiteAsyncConnection.InsertOrReplaceAllAsync() methods. [47de3e1] Adding SQLiteAsyncConnection.InsertOrReplaceAsync() method.
No problem. This is my first real contribution to an open source project, so I appreciate your patience. Next time will be much smoother, hopefully. :) I followed the style guide you linked with my commit message, including a line break after the summary, but Github is wanting to take the next line and shove it up into the first. Is this acceptable? I have no idea how to make it not do that. |
Yeah that's OK:) |
Noticed that the async library was missing
InsertOrReplaceAsync()
method, which I've found useful in the synchronous version, so I added it along with aInsertOrReplaceAll()
and correspondingInsertOrReplaceAllAsync()
methods and tests. @softlion has something similar in his large pull request, but that's been hanging around for a few months and I don't know if he has any plans to further pursue merging it.Sorry for the ugly diff on
SQLIteConnection.cs
-- the intermingling of theInsert()
,InsertAll()
, andInsertOrReplace()
methods really bugged me (makes them harder to find), so I segregated them. The only new thing in that file is theInsertOrReplaceAll()
method.