Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for FF exception (updated) #109

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

Heres the updated code. :)

This code doesn't actually do anything...

Could you share more information on how this error occurs? Perhaps you have a test case?

Owner

virajkanwade replied Jun 15, 2011

The line "if (prop in destination)" causes JS error in few FF versions.

Don't remember the exact error message and would take some time to setup the cross domain setup back to get it.

But as far as I remember, the problem is not in your code but FF. Sometimes, "key in var" raises JS error in FF.

It is just a hack around it. If FF raises the exception, just catch it and use false.

If I get the error back, will surely add it here.

Ok, but this code still don't do anything as in line 447 you are still doing prop in destination :)

Owner

virajkanwade replied Jun 16, 2011

It is supposed to be doing the same thing.

All it does is silently handles the JS exception raised in FF and the script continues executing.

Owner

virajkanwade replied Jun 16, 2011

Ohh. My bad.

I missed out one line.
if (prop in destination) { on 440-447 should be prop_in_destination. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment